Enable sample type checking for cosmos by kristapratico · Pull Request #39334 · Azure/azure-sdk-for-python

Krista Pratico (kristapratico) · 2025-01-21T21:18:16Z

This is already passing so enabling in CI so we can continue to validate samples with mypy

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

The pull request does not introduce [breaking changes]
CHANGELOG is updated for new features, bug fixes or other significant changes.
I have read the contribution guidelines.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

This is already passing so enabling in CI so we can continue to validate samples with mypy

Azure SDK Bot (azure-sdk) · 2025-01-21T21:41:54Z

API change check

API changes are not detected in this pull request.

Krista Pratico (kristapratico) · 2025-01-21T22:03:30Z

Pylint failure is unrelated and tracked in this issue: #33735

Krista Pratico (kristapratico) · 2025-01-23T19:03:42Z

/check-enforcer override

This is already passing so enabling in CI so we can continue to validate samples with mypy

* Azure AI Evaluation Release 1.2.0 * Azure AI Evaluation Release 1.2.0 * fix the intersphinx references for a new reference methodology (#39332) * handle only deleted files in a <language> - pullrequest build (#39266) Co-authored-by: Scott Beddall <scbedd@microsoft.com> * fix tests weekly (#39338) * [Storage] update perf tests core baseline (#39336) * [Storage] update perf tests core baseline * update storage file baselien * [AutoRelease] t2-computeschedule-2025-01-10-50036(can only be merged by SDK owner) (#39105) * code and test * Update CHANGELOG.md for new model properties --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> * [AutoRelease] t2-quota-2025-01-16-93059(can only be merged by SDK owner) (#39215) * code and test * update testcases * Update CHANGELOG.md to remove method details * Update changelog for quota operations changes * Update release date in CHANGELOG.md --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> * [AutoRelease] t2-servicenetworking-2025-01-21-47646(can only be merged by SDK owner) (#39322) * code and test * Remove duplicate method overloads from changelog * Update CHANGELOG.md to remove instance variables * Fix typo in changelog entry * Update CHANGELOG for version 2.0.0 --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> * Fix urls (#39259) * Fix urls (#39251) * fix url (#39255) * Fix urls (#39248) * Fix urls (#39246) * Content safety evals aggregate max from conversations (#39083) * add convo agg type, and have harm evals use max * analysis * correct enum name in docs * refactor checked enum into function field * cl and analysis * change enum name and update CL * change function names to private, allow agg type retrieval * PR comments * test serialization * CL * CI adjustment * try again * perf * skip perf * remove skip * Fix urls (#39129) * Fix urls (#39262) * Sync eng/common directory with azure-sdk-tools for PR 9668 (#39347) * Support incrementing semver prereleases with 'zero' versions * Make tests more explicit --------- Co-authored-by: Patrick Hallisey <pahallis@microsoft.com> * [ServiceBus/EventHub] lock pending deliveries on send (#38067) * [ServiceBus/EventHub] lock pending deliveries on send * remove misc logging * changelog + test * fix tests, remove session lock * remove logging from test * sync with sb * add todo in sender.py tfor temporary fix * bumped versions after jan 22 patch release (#39355) * Sync eng/common directory with azure-sdk-tools for PR 9656 (#39356) * Added label handle sdk-gen pipeline template Added common script to delete label from a PR * Update eng/common/scripts/Invoke-GitHubAPI.ps1 Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> --------- Co-authored-by: ray chen <raychen@microsoft.com> Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * Update package_utils.py (#39361) * [AutoRelease] t2-web-2024-11-15-26155(can only be merged by SDK owner) (#38561) * code and test * Update app_service_environments_create_or_update_multi_role_pool.py * udpate version * update-testcase * update testcases * update format * Update CHANGELOG.md * Update CHANGELOG.md * update version --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> * fix: Loosen psutil version requirement (#39354) * Enable sample type checking for cosmos (#39334) This is already passing so enabling in CI so we can continue to validate samples with mypy * update change log * change date format * change date format * change date format --------- Co-authored-by: Scott Beddall <45376673+scbedd@users.noreply.github.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Scott Beddall <scbedd@microsoft.com> Co-authored-by: Krista Pratico <krpratic@microsoft.com> Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> Co-authored-by: Xiang Yan <xiangsjtu@gmail.com> Co-authored-by: MilesHolland <108901744+MilesHolland@users.noreply.github.com> Co-authored-by: Patrick Hallisey <pahallis@microsoft.com> Co-authored-by: Peter Wu <162184229+weirongw23-msft@users.noreply.github.com> Co-authored-by: ray chen <raychen@microsoft.com> Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com> Co-authored-by: kdestin <101366538+kdestin@users.noreply.github.com>

This is already passing so enabling in CI so we can continue to validate samples with mypy

* Azure AI Evaluation Release 1.2.0 * Azure AI Evaluation Release 1.2.0 * fix the intersphinx references for a new reference methodology (Azure#39332) * handle only deleted files in a <language> - pullrequest build (Azure#39266) Co-authored-by: Scott Beddall <scbedd@microsoft.com> * fix tests weekly (Azure#39338) * [Storage] update perf tests core baseline (Azure#39336) * [Storage] update perf tests core baseline * update storage file baselien * [AutoRelease] t2-computeschedule-2025-01-10-50036(can only be merged by SDK owner) (Azure#39105) * code and test * Update CHANGELOG.md for new model properties --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> * [AutoRelease] t2-quota-2025-01-16-93059(can only be merged by SDK owner) (Azure#39215) * code and test * update testcases * Update CHANGELOG.md to remove method details * Update changelog for quota operations changes * Update release date in CHANGELOG.md --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> * [AutoRelease] t2-servicenetworking-2025-01-21-47646(can only be merged by SDK owner) (Azure#39322) * code and test * Remove duplicate method overloads from changelog * Update CHANGELOG.md to remove instance variables * Fix typo in changelog entry * Update CHANGELOG for version 2.0.0 --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> * Fix urls (Azure#39259) * Fix urls (Azure#39251) * fix url (Azure#39255) * Fix urls (Azure#39248) * Fix urls (Azure#39246) * Content safety evals aggregate max from conversations (Azure#39083) * add convo agg type, and have harm evals use max * analysis * correct enum name in docs * refactor checked enum into function field * cl and analysis * change enum name and update CL * change function names to private, allow agg type retrieval * PR comments * test serialization * CL * CI adjustment * try again * perf * skip perf * remove skip * Fix urls (Azure#39129) * Fix urls (Azure#39262) * Sync eng/common directory with azure-sdk-tools for PR 9668 (Azure#39347) * Support incrementing semver prereleases with 'zero' versions * Make tests more explicit --------- Co-authored-by: Patrick Hallisey <pahallis@microsoft.com> * [ServiceBus/EventHub] lock pending deliveries on send (Azure#38067) * [ServiceBus/EventHub] lock pending deliveries on send * remove misc logging * changelog + test * fix tests, remove session lock * remove logging from test * sync with sb * add todo in sender.py tfor temporary fix * bumped versions after jan 22 patch release (Azure#39355) * Sync eng/common directory with azure-sdk-tools for PR 9656 (Azure#39356) * Added label handle sdk-gen pipeline template Added common script to delete label from a PR * Update eng/common/scripts/Invoke-GitHubAPI.ps1 Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> --------- Co-authored-by: ray chen <raychen@microsoft.com> Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * Update package_utils.py (Azure#39361) * [AutoRelease] t2-web-2024-11-15-26155(can only be merged by SDK owner) (Azure#38561) * code and test * Update app_service_environments_create_or_update_multi_role_pool.py * udpate version * update-testcase * update testcases * update format * Update CHANGELOG.md * Update CHANGELOG.md * update version --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> * fix: Loosen psutil version requirement (Azure#39354) * Enable sample type checking for cosmos (Azure#39334) This is already passing so enabling in CI so we can continue to validate samples with mypy * update change log * change date format * change date format * change date format --------- Co-authored-by: Scott Beddall <45376673+scbedd@users.noreply.github.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Scott Beddall <scbedd@microsoft.com> Co-authored-by: Krista Pratico <krpratic@microsoft.com> Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> Co-authored-by: Xiang Yan <xiangsjtu@gmail.com> Co-authored-by: MilesHolland <108901744+MilesHolland@users.noreply.github.com> Co-authored-by: Patrick Hallisey <pahallis@microsoft.com> Co-authored-by: Peter Wu <162184229+weirongw23-msft@users.noreply.github.com> Co-authored-by: ray chen <raychen@microsoft.com> Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com> Co-authored-by: kdestin <101366538+kdestin@users.noreply.github.com>

This is already passing so enabling in CI so we can continue to validate samples with mypy

* Azure AI Evaluation Release 1.2.0 * Azure AI Evaluation Release 1.2.0 * fix the intersphinx references for a new reference methodology (Azure#39332) * handle only deleted files in a <language> - pullrequest build (Azure#39266) Co-authored-by: Scott Beddall <scbedd@microsoft.com> * fix tests weekly (Azure#39338) * [Storage] update perf tests core baseline (Azure#39336) * [Storage] update perf tests core baseline * update storage file baselien * [AutoRelease] t2-computeschedule-2025-01-10-50036(can only be merged by SDK owner) (Azure#39105) * code and test * Update CHANGELOG.md for new model properties --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> * [AutoRelease] t2-quota-2025-01-16-93059(can only be merged by SDK owner) (Azure#39215) * code and test * update testcases * Update CHANGELOG.md to remove method details * Update changelog for quota operations changes * Update release date in CHANGELOG.md --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> * [AutoRelease] t2-servicenetworking-2025-01-21-47646(can only be merged by SDK owner) (Azure#39322) * code and test * Remove duplicate method overloads from changelog * Update CHANGELOG.md to remove instance variables * Fix typo in changelog entry * Update CHANGELOG for version 2.0.0 --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> * Fix urls (Azure#39259) * Fix urls (Azure#39251) * fix url (Azure#39255) * Fix urls (Azure#39248) * Fix urls (Azure#39246) * Content safety evals aggregate max from conversations (Azure#39083) * add convo agg type, and have harm evals use max * analysis * correct enum name in docs * refactor checked enum into function field * cl and analysis * change enum name and update CL * change function names to private, allow agg type retrieval * PR comments * test serialization * CL * CI adjustment * try again * perf * skip perf * remove skip * Fix urls (Azure#39129) * Fix urls (Azure#39262) * Sync eng/common directory with azure-sdk-tools for PR 9668 (Azure#39347) * Support incrementing semver prereleases with 'zero' versions * Make tests more explicit --------- Co-authored-by: Patrick Hallisey <pahallis@microsoft.com> * [ServiceBus/EventHub] lock pending deliveries on send (Azure#38067) * [ServiceBus/EventHub] lock pending deliveries on send * remove misc logging * changelog + test * fix tests, remove session lock * remove logging from test * sync with sb * add todo in sender.py tfor temporary fix * bumped versions after jan 22 patch release (Azure#39355) * Sync eng/common directory with azure-sdk-tools for PR 9656 (Azure#39356) * Added label handle sdk-gen pipeline template Added common script to delete label from a PR * Update eng/common/scripts/Invoke-GitHubAPI.ps1 Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> --------- Co-authored-by: ray chen <raychen@microsoft.com> Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * Update package_utils.py (Azure#39361) * [AutoRelease] t2-web-2024-11-15-26155(can only be merged by SDK owner) (Azure#38561) * code and test * Update app_service_environments_create_or_update_multi_role_pool.py * udpate version * update-testcase * update testcases * update format * Update CHANGELOG.md * Update CHANGELOG.md * update version --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> * fix: Loosen psutil version requirement (Azure#39354) * Enable sample type checking for cosmos (Azure#39334) This is already passing so enabling in CI so we can continue to validate samples with mypy * update change log * change date format * change date format * change date format --------- Co-authored-by: Scott Beddall <45376673+scbedd@users.noreply.github.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Scott Beddall <scbedd@microsoft.com> Co-authored-by: Krista Pratico <krpratic@microsoft.com> Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> Co-authored-by: Xiang Yan <xiangsjtu@gmail.com> Co-authored-by: MilesHolland <108901744+MilesHolland@users.noreply.github.com> Co-authored-by: Patrick Hallisey <pahallis@microsoft.com> Co-authored-by: Peter Wu <162184229+weirongw23-msft@users.noreply.github.com> Co-authored-by: ray chen <raychen@microsoft.com> Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com> Co-authored-by: kdestin <101366538+kdestin@users.noreply.github.com>

Enable sample type checking for cosmos

020ac6c

This is already passing so enabling in CI so we can continue to validate samples with mypy

Krista Pratico (kristapratico) requested review from a team and Anna Tisch (annatisch) as code owners January 21, 2025 21:18

github-actions Bot added the Cosmos label Jan 21, 2025

Libba Lawrence (l0lawrence) approved these changes Jan 23, 2025

View reviewed changes

Krista Pratico (kristapratico) merged commit 973faf0 into main Jan 23, 2025

Krista Pratico (kristapratico) deleted the kristapratico-patch-12 branch January 23, 2025 19:04

Waqas Javed (w-javed) pushed a commit that referenced this pull request Jan 23, 2025

Enable sample type checking for cosmos (#39334)

21d2449

This is already passing so enabling in CI so we can continue to validate samples with mypy

Waqas Javed (w-javed) pushed a commit to w-javed/azure-sdk-for-python that referenced this pull request Jan 23, 2025

Enable sample type checking for cosmos (Azure#39334)

74d3c06

This is already passing so enabling in CI so we can continue to validate samples with mypy

Allen Kim (allenkim0129) pushed a commit to allenkim0129/azure-sdk-for-python that referenced this pull request Jan 27, 2025

Enable sample type checking for cosmos (Azure#39334)

bb51773

This is already passing so enabling in CI so we can continue to validate samples with mypy

Libba Lawrence (l0lawrence) pushed a commit to l0lawrence/azure-sdk-for-python that referenced this pull request Feb 19, 2025

Enable sample type checking for cosmos (Azure#39334)

4338d0c

This is already passing so enabling in CI so we can continue to validate samples with mypy

Navigation Menu

Uh oh!

Enable sample type checking for cosmos - #39334

Enable sample type checking for cosmos#39334
Krista Pratico (kristapratico) merged 1 commit into
mainfrom
kristapratico-patch-12

Krista Pratico (kristapratico) commented Jan 21, 2025

Uh oh!

Azure SDK Bot (azure-sdk) commented Jan 21, 2025

Uh oh!

Krista Pratico (kristapratico) commented Jan 21, 2025

Uh oh!

Krista Pratico (kristapratico) commented Jan 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Krista Pratico (kristapratico) commented Jan 21, 2025

Description

All SDK Contribution checklist:

General Guidelines and Best Practices

Testing Guidelines

Uh oh!

Azure SDK Bot (azure-sdk) commented Jan 21, 2025

Uh oh!

Krista Pratico (kristapratico) commented Jan 21, 2025

Uh oh!

Krista Pratico (kristapratico) commented Jan 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants